Committed.
On Fri, Mar 28, 2025 at 10:25:26AM -0500, Nathan Bossart wrote:
> On Thu, Mar 27, 2025 at 03:31:27PM +0700, John Naylor wrote:
>> On Thu, Mar 27, 2025 at 10:38 AM Nathan Bossart
>> <nathandbossart@gmail.com> wrote:
>>> I also noticed a silly mistake in 0003 that would cause us to potentially
>>> skip part of the tail. That should be fixed now.
>>
>> I'm not sure whether that meant it could return the wrong answer, or
>> just make more work for paths further down.
>> If the former, then our test coverage is not adequate.
>
> This one is my bad. I think the issue is that I'm writing this stuff on a
> machine that doesn't have SVE, so obviously my tests are happy as long as
> the Neon stuff is okay. We do have some tests in bit.sql that should in
> theory find this stuff. I'll be sure to verify all of this on a machine
> with SVE...
I verified that the tests failed without this fix on a machine with SVE.
--
nathan
