Re: plpgsql-trigger.html: Format TG_ variables as table (patch) - Mailing list pgsql-hackers

Re: Dagfinn Ilmari Mannsåker
> > Actually, just omitting the whole prefix works best.
> >
> > TG_WHEN (text)
> >
> >     BEFORE, AFTER, or INSTEAD OF, depending on the trigger's definition.
> 
> The attached patch does not reflect this, did you attach an old version?

Forgot to git commit before exporting the patch, thanks for catching!

> > I also shortened some "name of table" to just "table". Since the data
> > type is "name", it's clear what "table" means.
> 
> I think it reads better with the definite article and initial capital,
> e.g. "The table that triggered ….".

Since that's not a complete sentence anyway, I think "The" isn't
necessary.

> > -     <term><varname>NEW</varname></term>
> > +     <term><varname>NEW</varname> (record)</term>
> 
> The type names should still be wrapped in <type>, like they were before.

Updated.

Thanks,
Christoph