Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~ - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~
Date
Msg-id Yx54ksc+zBkm2Uoi@paquier.xyz
Whole thread Raw
In response to Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~
List pgsql-hackers
On Mon, Sep 12, 2022 at 09:42:25AM +1200, Thomas Munro wrote:
> When looking the function up it made sense to use the name ending in
> '...A', but when calling directly I think we shouldn't use the A
> suffix, we should let the <winldap.h> macros do that for us[1].  (I
> wondered for a moment if that would even make Windows and Unix code
> the same, but sadly not due to the extra NULL arguments.)

Good idea, I did not noticed this part.  This should work equally, so
done this way and applied.  I am keeping an eye on the buildfarm.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: pg15b4: FailedAssertion("TransactionIdIsValid(xmax)
Next
From: Justin Pryzby
Date:
Subject: Re: Background writer and checkpointer in crash recovery