Postgres Pro
Downloads
Home   >   mailing lists

Re: plpgsql-trigger.html: Format TG_ variables as table (patch) - Mailing list pgsql-hackers

From Christoph Berg
Subject Re: plpgsql-trigger.html: Format TG_ variables as table (patch)
Date
Msg-id Yw8xAZhbvlzJR3Jf@msg.df7cb.de
Whole thread Raw
In response to Re: plpgsql-trigger.html: Format TG_ variables as table (patch)  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Responses Re: plpgsql-trigger.html: Format TG_ variables as table (patch)
List pgsql-hackers
Tree view 
Re: Peter Eisentraut
> I find the new version even harder to read.  The catalog_table_entry stuff
> doesn't really make sense here, since what you have before is already a
> definition list, and afterwards you have the same, just marked up
> "incorrectly".

Fair enough. For comparison, this is what yesterday's patch looked
like: https://www.df7cb.de/s/2022-08-31.115813.w5UvAS.png

> We could move the data type in the <term>, similar to how you did it in your
> patch.

The new version of the patch just moves up the data types, and removes
the extra clutter from the beginnings of each description:

https://www.df7cb.de/s/2022-08-31.115857.LkkKl8.png

Christoph
Attachment

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: plpgsql-trigger.html: Format TG_ variables as table (patch)
Next
From: Asif Rehman
Date:
Subject: Re: [PATCH] Fix alter subscription concurrency errors