Re: Collect ObjectAddress for ATTACH DETACH PARTITION to use in event trigger - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Collect ObjectAddress for ATTACH DETACH PARTITION to use in event trigger
Date
Msg-id YuYA+APfGICHH0RV@paquier.xyz
Whole thread Raw
In response to RE: Collect ObjectAddress for ATTACH DETACH PARTITION to use in event trigger  ("houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>)
Responses RE: Collect ObjectAddress for ATTACH DETACH PARTITION to use in event trigger
List pgsql-hackers
On Sat, Jul 30, 2022 at 01:13:52PM +0000, houzj.fnst@fujitsu.com wrote:
> I am not against returning the objaddr for cases related to RLS and RelOption.
> But just to confirm, do you have a use case to use the returned address(relation itself)
> for RLS or RelOptions in event trigger ? I asked this because when I tried to
> deparse the subcommand of ALTER TABLE. It seems enough to use the information
> inside the parse tree to deparse the RLS and RelOptions related subcommands.

You are right here, there is little point in returning the relation
itself.  I have removed these modifications, added a couple of extra
commands for some extra coverage, and applied all that.  I have
finished by splitting the extension of test_ddl_deparse/ and the
addition of ObjectAddress for the attach/detach into their own commit,
mainly for clarity.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Julien Rouhaud
Date:
Subject: Re: [PATCH] Add extra statistics to explain for Nested Loop
Next
From: Noah Misch
Date:
Subject: Re: Race between KeepFileRestoredFromArchive() and restartpoint