Re: Supply restore_command to pg_rewind via CLI argument - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Supply restore_command to pg_rewind via CLI argument
Date
Msg-id Yk58UsxW4w4tZMJA@paquier.xyz
Whole thread Raw
In response to Re: Supply restore_command to pg_rewind via CLI argument  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
On Thu, Nov 04, 2021 at 01:55:43PM +0100, Daniel Gustafsson wrote:
>> On 14 Sep 2021, at 16:05, Andrey Borodin <x4mmm@yandex-team.ru> wrote:
>>> Do we actually need --target-restore-command at all? It seems to me
>>> that we have all we need with --restore-target-wal, and that's not
>>> really instinctive to pass down a command via another command..
>>
>> Currently we know that --restore-target-wal is not enough if postgresql.conf does not reside within PGDATA.
>
> That's a useful reason which wasn't brought up in the earlier thread, and may
> tip the scales in favor.

It does now, as of 0d5c3875.  FWIW, I am not much a fan of the design
where we pass down a command line as an option value of a different
command line (more games with quoting comes into mind first), and
--config-file should give enough room for the case of this thread.  I
have switched the status of the patch to reflect that.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pg_dump new feature: exporting functions only. Bad or good idea ?
Next
From: "kuroda.hayato@fujitsu.com"
Date:
Subject: RE: Handle infinite recursion in logical replication setup