Re: Windows now has fdatasync() - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Windows now has fdatasync()
Date
Msg-id Yk/f+Xq9WWldRK9k@paquier.xyz
Whole thread Raw
In response to Re: Windows now has fdatasync()  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, Apr 08, 2022 at 12:40:55AM -0400, Tom Lane wrote:
> As long as the C11-isms are in MSVC-only code, it seems like this is
> exactly equivalent to setting a minimum MSVC version.  I don't see
> an objection-in-principle there, it's just a practical question of
> how far back is reasonable to support MSVC versions.  (That's very
> distinct from how far back we need the built code to run.)

Good question.  Older versions of VS are available, so this is not a
problem:
https://visualstudio.microsoft.com/vs/older-downloads/

I think that we should at least drop 2013, as there is a bunch of
stuff related to _MSC_VER < 1900 that could be removed with that,
particularly for locales.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Laetitia Avrot
Date:
Subject: Re: pg_dump new feature: exporting functions only. Bad or good idea ?
Next
From: Michael Paquier
Date:
Subject: Re: API stability [was: pgsql: Fix possible recovery trouble if TRUNCATE overlaps a checkpoint.]