(Added Jeevan in CC, for awareness)
On Mon, Jan 03, 2022 at 03:35:57PM +0000, gkokolatos@pm.me wrote:
> I propose to initialize streamer to NULL when declared at the top of
> CreateBackupStreamer().
Yes, that may be noisy. Done this way.
> You can see that after the check_pg_config() test, only 3 tests follow,
> namely:
> * $node->command_ok()
> * is(scalar(), ...)
> * is($gzip_is_valid, ...)
Indeed. The CF bot was complaining about that, actually.
Thinking more about this stuff, pg_basebackup --compress is an option
that exists already for a couple of years, and that's independent of
the backend-side compression that Robert and Jeevan are working on, so
I'd like to move on this code cleanup. We can always figure out the
LZ4 part for pg_basebackup after, if necessary.
Attached is an updated patch. The CF bot should improve with that.
--
Michael
