Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c
Date
Msg-id YT65clO3UOG9isEV@paquier.xyz
Whole thread Raw
In response to Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c  ("Euler Taveira" <euler@eulerto.com>)
Responses Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c
List pgsql-hackers
On Sun, Sep 12, 2021 at 10:14:36PM -0300, Euler Taveira wrote:
> On Sun, Sep 12, 2021, at 8:02 PM, Bossart, Nathan wrote:
>> nitpick: It looks like there's an extra set of parentheses around
>> errmsg().
>
> Indeed. Even the requirement for extra parenthesis around auxiliary function
> calls was removed in v12 (e3a87b4991cc2d00b7a3082abb54c5f12baedfd1).

Yes.  The patch makes sense.  I am not seeing any other places that
could be grouped, so that looks fine as-is.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Add jsonlog log_destination for JSON server logs
Next
From: Michael Paquier
Date:
Subject: Re: TAP test for recovery_end_command