Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c
Date
Msg-id CALj2ACX8rqYL7FyXzSZTNRcxU29LygxCf74vDf0XfDHtkNu68A@mail.gmail.com
Whole thread Raw
In response to Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c
List pgsql-hackers
On Mon, Sep 13, 2021 at 8:07 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Sun, Sep 12, 2021 at 10:14:36PM -0300, Euler Taveira wrote:
> > On Sun, Sep 12, 2021, at 8:02 PM, Bossart, Nathan wrote:
> >> nitpick: It looks like there's an extra set of parentheses around
> >> errmsg().
> >
> > Indeed. Even the requirement for extra parenthesis around auxiliary function
> > calls was removed in v12 (e3a87b4991cc2d00b7a3082abb54c5f12baedfd1).
>
> Yes.  The patch makes sense.  I am not seeing any other places that
> could be grouped, so that looks fine as-is.

Thanks all for taking a look at the patch. Here's the CF entry -
https://commitfest.postgresql.org/35/3319/

Regards,
Bharath Rupireddy.



pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c
Next
From: Justin Pryzby
Date:
Subject: document the need to analyze partitioned tables