Postgres Pro
Downloads
Home   >   mailing lists

Re: cleanup in open_auth_file - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: cleanup in open_auth_file
Date
Msg-id Y37GlHVLR6UUvso+@paquier.xyz
Whole thread Raw
In response to Re: cleanup in open_auth_file  (Ted Yu <yuzhihong@gmail.com>)
List pgsql-hackers
Tree view 
On Wed, Nov 23, 2022 at 05:09:22PM -0800, Ted Yu wrote:
> Thinking more on this.
> The context should be created when the file is successfully opened.

Indeed.  Both operations ought to be done in the reverse order, or we
would run into leaks in the postmaster on reload if pg_ident.conf has
been removed, for example, and this is prefectly valid.  That's what
the previous logic did, actually.  Will fix in a minute..
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: ssl tests aren't concurrency safe due to get_free_port()
Next
From: Andrew Dunstan
Date:
Subject: Re: More efficient build farm animal wakeup?