Postgres Pro
Downloads
Home   >   mailing lists

Re: cleanup in open_auth_file - Mailing list pgsql-hackers

From Ted Yu
Subject Re: cleanup in open_auth_file
Date
Msg-id CALte62xsDNY9MornAnYzR=vGW6VCYK9Qa1=UMEvcM2RLs-vZrg@mail.gmail.com
Whole thread Raw
In response to cleanup in open_auth_file  (Ted Yu <yuzhihong@gmail.com>)
Responses Re: cleanup in open_auth_file
List pgsql-hackers
Tree view


On Wed, Nov 23, 2022 at 4:54 PM Ted Yu <yuzhihong@gmail.com> wrote:
Hi,
I was looking at the following commit:

commit efc981627a723d91e86865fb363d793282e473d1
Author: Michael Paquier <michael@paquier.xyz>
Date:   Thu Nov 24 08:21:55 2022 +0900

    Rework memory contexts in charge of HBA/ident tokenization

I think when the file cannot be opened, the context should be deleted.

Please see attached patch.

I also modified one comment where `deleted` would be more appropriate verb for the context.

Cheers

Thinking more on this.
The context should be created when the file is successfully opened.

Please take a look at patch v2. 
Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: odd buildfarm failure - "pg_ctl: control file appears to be corrupt"
Next
From: Andrew Dunstan
Date:
Subject: Re: ssl tests aren't concurrency safe due to get_free_port()