Re: Add table access method as an option to pgbench - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Add table access method as an option to pgbench
Date
Msg-id X73SZQNSPxRC1mCP@paquier.xyz
Whole thread Raw
In response to Add table access method as an option to pgbench  (David Zhang <david.zhang@highgo.ca>)
Responses Re: Add table access method as an option to pgbench  (David Zhang <david.zhang@highgo.ca>)
Re: Add table access method as an option to pgbench  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Tue, Nov 24, 2020 at 03:32:38PM -0800, David Zhang wrote:
> But, providing another option for the end user may not be a bad idea, and it
> might make the tests easier at some points.

My first thought is that we have no need to complicate pgbench with
this option because there is a GUC able to do that, but we do that for
tablespaces, so...  No objections from here.

> The attached file is quick patch for this.
>
> Thoughts?

This patch does not apply on HEAD, where you can just use
appendPQExpBuffer() to append the new clause to the CREATE TABLE
query.  This needs proper documentation.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Euler Taveira
Date:
Subject: Re: Any objections to implementing LogicalDecodeMessageCB for pgoutput?
Next
From: Tom Lane
Date:
Subject: Re: About adding a new filed to a struct in primnodes.h