Postgres Pro
Downloads
Home   >   mailing lists

RE: [POC] Fast COPY FROM command for the table with foreign partitions - Mailing list pgsql-hackers

From tsunakawa.takay@fujitsu.com
Subject RE: [POC] Fast COPY FROM command for the table with foreign partitions
Date
Msg-id TYAPR01MB29909FDCD92F5EEE68E37767FE649@TYAPR01MB2990.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: [POC] Fast COPY FROM command for the table with foreign partitions  (Andrey Lepikhov <a.lepikhov@postgrespro.ru>)
Responses Re: [POC] Fast COPY FROM command for the table with foreign partitions
List pgsql-hackers
Tree view 
From: Andrey Lepikhov <a.lepikhov@postgrespro.ru>
> Macros _() at the postgresExecForeignCopy routine:
> if (PQputCopyEnd(conn, OK ? NULL : _("canceled by server")) <= 0)
>
> uses gettext. Under linux it is compiled ok, because (as i understood)
> uses standard implementation of gettext:
> objdump -t contrib/postgres_fdw/postgres_fdw.so | grep 'gettext'
> gettext@@GLIBC_2.2.5
>
> but in MacOS (and maybe somewhere else) we need to explicitly link
> libintl library in the Makefile:
> SHLIB_LINK += $(filter -lintl, $(LIBS)
>
> Also, we may not use gettext at all in this part of the code.

I'm afraid so, because no extension in contrib/ has po/ directory.  I just removed _() and rebased the patch on HEAD.


    Regards
Takayuki     Tsunakawa
Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: PostmasterIsAlive() in recovery (non-USE_POST_MASTER_DEATH_SIGNAL builds)
Next
From: "kuroda.hayato@fujitsu.com"
Date:
Subject: RE: [PATCH] Tracking statements entry timestamp in pg_stat_statements