RE: Remove unused argument from ApplyLogicalMappingFile() - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: Remove unused argument from ApplyLogicalMappingFile()
Date
Msg-id TY7PR01MB1455477C72A1765233D7D13D4F591A@TY7PR01MB14554.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Remove unused argument from ApplyLogicalMappingFile()  (Yugo Nagata <nagata@sraoss.co.jp>)
Responses Re: Remove unused argument from ApplyLogicalMappingFile()
List pgsql-hackers
Dear Nagata-san,

> I noticed that ApplyLogicalMappingFile() has an unused argument.
> If there is no specific reason for keeping it, I think it could be
> removed. I have attached a small patch that removes this argument.

Good catch. I found that ApplyLogicalMappingFile() has the argument since it was
introduced (b89e151) and was not used from the beginning. Maybe it was a
copy-to-paste mistake from UpdateLogicalMappings()?
I removed the argument and ran tests for subscription, they could be passed.

Best regards,
Hayato Kuroda
FUJITSU LIMITED




pgsql-hackers by date:

Previous
From: shveta malik
Date:
Subject: Re: Skipping schema changes in publication
Next
From: Soumya S Murali
Date:
Subject: Re: Pasword expiration warning