Request a Demo
Home   >   mailing lists

Re: Remove unused argument from ApplyLogicalMappingFile() - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Remove unused argument from ApplyLogicalMappingFile()
Date
Msg-id CAHGQGwFFZg6Zehej4o-YKUn59R4+ugtowmCU+kbteQizqnYsBw@mail.gmail.com
Whole thread Raw
In response to RE: Remove unused argument from ApplyLogicalMappingFile()  ("Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>)
Responses Re: Remove unused argument from ApplyLogicalMappingFile()
List pgsql-hackers
Tree view 
On Wed, Jan 28, 2026 at 2:18 PM Hayato Kuroda (Fujitsu)
<kuroda.hayato@fujitsu.com> wrote:
>
> Dear Nagata-san,
>
> > I noticed that ApplyLogicalMappingFile() has an unused argument.
> > If there is no specific reason for keeping it, I think it could be
> > removed. I have attached a small patch that removes this argument.

Thanks for the patch! I will commit it.


> Good catch. I found that ApplyLogicalMappingFile() has the argument since it was
> introduced (b89e151) and was not used from the beginning.

Yes.


> I removed the argument and ran tests for subscription, they could be passed.

Thanks for the test!

Regards,

--
Fujii Masao

pgsql-hackers by date:

Previous
From: jian he
Date:
Subject: Re: ON CONFLICT DO SELECT (take 3)
Next
From: Ahmed Et-tanany
Date:
Subject: [PATCH] Add max_logical_replication_slots GUC