RE: [PATCH] Support automatic sequence replication - Mailing list pgsql-hackers

On Monday, March 9, 2026 11:17 AM Kuroda, Hayato/黒田 隼人 <kuroda.hayato@fujitsu.com> wrote:
> Few comments.

Thanks for the comments.

> 
> 03.
> Can we describe needed privileges? IIUC, initial sync needs the UPDATE
> privilege, additionally periodic synch needs SELECT privilege.

I could not find existing doc for the privilege required for table sync or
sequence sync, so I think we can consider that as a separate patch.

> 
> 04.
> ```
> +               long            sleep_ms = SEQSYNC_MIN_SLEEP_MS;
> ```
> 
> This is used in the for loop, make it the loop-specific variable.

This value should survive across sync loop as it's dynamically
adjusted in the loop.

Other comments have been addressed in latest version.

Best Regards,
Hou zj