RE: [PATCH] Support automatic sequence replication - Mailing list pgsql-hackers

Dear Hou,

Thanks for uprating the patch. Few comments.

01.
The patch needs to be rebased, because of the missing inclusion of wait_event.h.
It might be affected by the commit 868825aae.

02. start_sequence_sync
Missing ProcessConfigFile() in the loop. Now it's done only in copy_sequences(),
but we can reach there when some sequences need to be synchronized.

03.
Can we describe needed privileges? IIUC, initial sync needs the UPDATE privilege,
additionally periodic synch needs SELECT privilege.

04.
```
+               long            sleep_ms = SEQSYNC_MIN_SLEEP_MS;
```

This is used in the for loop, make it the loop-specific variable.

Best regards,
Hayato Kuroda
FUJITSU LIMITED