I don't see this as half baked error checking, but rather, as error
reporting during a "half baked conversion". I prefer to know when the
converter encounters something it doesn't understand, rather than having
it silently enter nulls into the db.
It was the original error reporting that helped me find this bug, I
suppose.
Kind regards,
Boris van Schooten
On Thu, 5 May 2005, Tom Lane wrote:
> Boris van Schooten <schooten@cs.utwente.nl> writes:
> > Looks good to me. I'd prefer to have a warning message (if (verbose)
> > fprintf stderr) for each of the exceptional conditions though. I'm even
> > so paranoid I prefer to have the verbose switch on by default.
>
> Don't really see the need for it. What we are doing here is trusting to
> the backend to error-check the input, rather than making a half-baked
> attempt to do error checking in dbf2pg.
>
> regards, tom lane
>