Re: [PATCHES] (Modified) Patch request for PostgreSQL 7.4 for HP-UX - Mailing list pgsql-bugs

From Peter Eisentraut
Subject Re: [PATCHES] (Modified) Patch request for PostgreSQL 7.4 for HP-UX
Date
Msg-id Pine.LNX.4.44.0311251535360.11097-100000@peter.localdomain
Whole thread Raw
In response to (Modified) Patch request for PostgreSQL 7.4 for HP-UX IA-64  ("ViSolve Open Source Team" <opensrc_support_hp@visolve.com>)
Responses Re: [PATCHES] (Modified) Patch request for PostgreSQL 7.4 for HP-UX  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
ViSolve Open Source Team writes:

> 1.  s_lock.h: modified with inline tas code for the HP-C compiler

What is this line all about?

+#if defined(__HP_aCC) || defined(__HP_cc)

There are no other compilers supported, so this seems redundant.

> 2.  genbki.sh: a one-line change that fixes a string concatenation problem with the
>     HP-C compiler (specific to included .c files).

You're doing this:

-TMPFILE="$TMPDIR/genbkitmp$$.c"
+TMPFILE="$TMPDIR/genbkitmp$$.h"

I'm afraid this will not fly, because calling the preprocessor is only
portable on .c files.  Generally, it's also unwise to rely in this kind of
subtle side effect.  We need a general solution.

--
Peter Eisentraut   peter_e@gmx.net


pgsql-bugs by date:

Previous
From: Seum-Lim Gan
Date:
Subject: Re: Fwd: Solaris build of 7.4 problem with
Next
From: Javier Carlos
Date:
Subject: Re: SELECT with MANY tables