Re: pgsql/src/bin/pg_ctl pg_ctl.sh - Mailing list pgsql-committers

From Peter Eisentraut
Subject Re: pgsql/src/bin/pg_ctl pg_ctl.sh
Date
Msg-id Pine.LNX.4.30.0107112118500.679-100000@peter.localdomain
Whole thread Raw
In response to Re: pgsql/src/bin/pg_ctl pg_ctl.sh  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: pgsql/src/bin/pg_ctl pg_ctl.sh
List pgsql-committers
I wrote:

> >     Move export PGDATA to the proper place.
>
> This is completely broken.  The old place was right.

Correction:  The new place also seems to be okay, but 'export VAR=stuff'
is not portable,  You need to split it into two commands.

> > Quote some variable substitutions.
>
> You don't need to quote the argument to 'case'.  Please don't do that, it
> makes things less readable.

Also, you don't need to quote the right side of

FOO=$BAR

--
Peter Eisentraut   peter_e@gmx.net   http://funkturm.homeip.net/~peter


pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: pgsql/src/bin/pg_ctl pg_ctl.sh
Next
From: Bruce Momjian
Date:
Subject: Re: pgsql/src/bin/pg_ctl pg_ctl.sh