Re: pgsql/src/bin/pg_ctl pg_ctl.sh - Mailing list pgsql-committers

From Peter Eisentraut
Subject Re: pgsql/src/bin/pg_ctl pg_ctl.sh
Date
Msg-id Pine.LNX.4.30.0107112111060.679-100000@peter.localdomain
Whole thread Raw
In response to pgsql/src/bin/pg_ctl pg_ctl.sh  (Bruce Momjian - CVS <momjian@hub.org>)
Responses Re: pgsql/src/bin/pg_ctl pg_ctl.sh  (Bruce Momjian <pgman@candle.pha.pa.us>)
Re: pgsql/src/bin/pg_ctl pg_ctl.sh  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-committers
Bruce Momjian - CVS writes:

> CVSROOT:    /home/projects/pgsql/cvsroot
> Module name:    pgsql
> Changes by:    momjian@hub.org    01/07/11 12:16:53
>
> Modified files:
>     src/bin/pg_ctl : pg_ctl.sh
>
> Log message:
>     Move export PGDATA to the proper place.

This is completely broken.  The old place was right.

> Quote some variable substitutions.

You don't need to quote the argument to 'case'.  Please don't do that, it
makes things less readable.

--
Peter Eisentraut   peter_e@gmx.net   http://funkturm.homeip.net/~peter


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql/src backend/libpq/pqcomm.c include/confi ...
Next
From: Bruce Momjian - CVS
Date:
Subject: pgsql/src/pl/plpgsql/src gram.y pl_comp.c pl_e ...