Re: [PATCHES] Fix for psql core dumping on bad user - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [PATCHES] Fix for psql core dumping on bad user
Date
Msg-id Pine.LNX.4.30.0104181916340.762-100000@peter.localdomain
Whole thread Raw
Responses Re: Re: [PATCHES] Fix for psql core dumping on bad user
List pgsql-hackers
D. Hageman writes:

> The postgresql interactive terminal will dump core on any script that is
> run via the -f command line option if their exists a connect line without
> a valid user.  An example connect line is in one of the attached files.

Okay, I've found the problem.  When the connection fails, psql momentarily
runs without a valid database connection.  When it does that, the
multibyte encoding has the invalid value -1.  (You need to compile with
multibyte enabled to reproduce this.)  With that value, PQmblen() has
trouble when it parses the next line.  Perhaps PQmblen() should simply
return 1 when it is passed an invalid encoding.  In any case it should do
better than dump core.

-- 
Peter Eisentraut   peter_e@gmx.net   http://funkturm.homeip.net/~peter



pgsql-hackers by date:

Previous
From: Alex Pilosov
Date:
Subject: Re: [BUG] views and functions on relations
Next
From: Joel Burton
Date:
Subject: [BUG?] tgconstrrelid doesn't survive a dump/restore