Ungraceful handling of fatal flex errors - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Ungraceful handling of fatal flex errors
Date
Msg-id Pine.LNX.4.30.0101271518550.1492-100000@peter.localdomain
Whole thread Raw
Responses Re: Ungraceful handling of fatal flex errors
List pgsql-hackers
A fatal scanner error (likely a memory exhaustion problem) causes a
straight exit() without clean up, which causes a system-wide restart.
This should fix it:

*** scan.l      2001/01/24 19:43:03     1.85
--- scan.l      2001/01/27 14:14:29
***************
*** 55,60 ****
--- 55,62 ---- /* No reason to constrain amount of data slurped per myinput() call. */ #define YY_READ_BUF_SIZE
16777216

+ #define YY_FATAL_ERROR(msg) elog(FATAL, "%s", (msg))
+ #else /* !FLEX_SCANNER */
 #undef input

But you will now get an unavoidable

scan.c:2145: warning: `yy_fatal_error' defined but not used

Objections or concerns?

-- 
Peter Eisentraut      peter_e@gmx.net       http://yi.org/peter-e/



pgsql-hackers by date:

Previous
From: Vince Vielhaber
Date:
Subject: Re: Which version?
Next
From: Peter Eisentraut
Date:
Subject: Re: wrong query plan in 7.1beta3