Re: RPMS for 7.1beta3 being uploaded. - Mailing list pgsql-hackers

Lamar Owen writes:

> Ok, I have a first set of 7.1beta3 RPMs uploading now.  These RPMs pass
> regression on my home RedHat 6.2 machine, which has all locale environment
> variables disabled (/etc/sysconfig/i18n deleted and a reboot).

Some thoughts:

Re: rpm-pgsql-7.1beta3.patch

| diff -uNr postgresql-7.1beta3.orig/src/Makefile.shlib postgresql-7.1beta3/src/Makefile.shlib
| --- postgresql-7.1beta3.orig/src/Makefile.shlib Wed Dec  6 14:37:08 2000
| +++ postgresql-7.1beta3/src/Makefile.shlib      Mon Jan 15 01:50:04 2001
|@@ -160,7 +160,7 @@
|
|  ifeq ($(PORTNAME), linux)
|    shlib                        := lib$(NAME)$(DLSUFFIX).$(SO_MAJOR_VERSION).$(SO_MINOR_VERSION)
| -  LINK.shared          = $(COMPILER) -shared -Wl,-soname,$(soname)
| +  LINK.shared          = $(COMPILER) -shared -Wl
|  endif

This cannot possibly be right.

| diff -uNr postgresql-7.1beta3.orig/src/Makefile.shlib~ postgresql-7.1beta3/src/Makefile.shlib~

???

| -#!/usr/local/bin/perl -w
| +#!/usr/bin/perl -w
(and more of these for Python)

I think this should be fixed to read

#! /usr/bin/env perl

Any comments?


Re: spec file

| # I hope this works....
|
| %ifarch ia64
| ln -s linux_i386 src/template/linux
| %endif

It definitely won't...

| # If libtool installed, copy some files....
| if [ -d /usr/share/libtool ]
| then
|         cp /usr/share/libtool/config.* .
| fi

This is useless (because the config.* files are not in src/ anymore) and
(if it were fixed) not recommendable because config.{guess,sub} is not
compatible to itself, *especially* in terms of Linux recognition.  You
really should use the ones PostgreSQL comes with.

| %ifarch ppc
| NEW_CFLAGS=`echo $CFLAGS|xargs -n 1|grep -v "\-O"|xargs -n 100`
| NEW_CFLAGS="$NEW_CFLAGS -O0"

This is no longer necessary.

| ./configure --enable-hba --enable-locale  --with-CXX --prefix=/usr\

There is no option called '--enable-hba'.  And I think you're supposed to
use %{configure}.

| %if %tkpkg
|         --with-tk --with-x \
| %endif

There is no '--with-x'.  '--with-tk' is the default if '--with-tcl' was
given; you should use '--without-tk' if you don't want it.

| %if %jdbc
|         --with-java \
| %endif

There is no such option.

| %ifarch alpha
|         --with-template=linux_alpha \
| %endif

This won't work and is not necessary.

| make COPT="$NEW_CFLAGS" DESTDIR=$RPM_BUILD_ROOT/usr all

You should set CFLAGS when you run configure. (%{configure} will do that.)
DESTDIR is only useful when you run 'make install'.  And DESTDIR should
not include /usr.

| make all PGDOCS=unpacked -C doc

Not sure what this is supposed to do, but I don't think it will do what
you expect.  The docs are installed automatically.

| mkdir -p $RPM_BUILD_ROOT/usr/{include/pgsql,lib,bin}
| mkdir -p $RPM_BUILD_ROOT%{_mandir}

You don't need that, the directories are made automatically.

| make DESTDIR=$RPM_BUILD_ROOT -C src install

No '-C src'.

| # copy over the includes needed for SPI development.
| pushd src/include
| /lib/cpp -M -I. -I../backend executor/spi.h | \
|         xargs -n 1| \
|         grep \\W| \
|         grep -v ^/| \
|         grep -v spi.o | \
|         grep -v spi.h | \
|         sort | \
|         cpio -pdu $RPM_BUILD_ROOT/usr/include/pgsql

I think the standard installed set of headers is sufficient.

| %if %pgaccess
|         # pgaccess installation

Pgaccess is installed automatically when you configure --with-tcl.

| # Move the PL's to the right place
| mv $RPM_BUILD_ROOT/usr/lib/pl*.so $RPM_BUILD_ROOT/usr/share/postgresql

You should not put architecture specific files into share/.  I'm sure this
is in violation of FHS.  (I'm amazed createlang finds it there.)


Re: sub-packages

* pg_id should be in server

* What were the last thoughts about renaming the <nothing> package to -clients?

* pg_upgrade won't work, so you might as well not install it.  It will probably be disabled before we release.

* You're missing pg_config in the -devel package.


These are the things I could find at first glance. ;-)

-- 
Peter Eisentraut      peter_e@gmx.net       http://yi.org/peter-e/