Tom Lane writes:
> Peter Eisentraut <peter_e@gmx.net> writes:
> > I don't like the code in fe-connect.c one bit, it's way messed up.
>
> Yes. We've accepted several extremely questionable (not to mention
> poorly documented or completely undocumented) "features" in there
> recently. If I'd been paying more attention I would've voted against
> both the URL patch and the SERVICE patch, as I think they're both
> less than fully baked --- and I don't see word one about either in
> the libpq SGML documentation.
>
> Someone should probably review the history and either fix or remove
> the more dubious patches, before we get stuck having to be
> backwards-compatible with bad ideas.
I'm going to disable the URL patch, since it doesn't seem to work and
breaks legitimate uses of database names with funny characters. The
service patch seemed kind of useful, but since it's not documented and I
don't feel like finding out, I think we can let it go the SSL way, i.e.,
sort out for next release.
--
Peter Eisentraut peter_e@gmx.net http://yi.org/peter-e/
