Re: Warnings triggered by recent includefile cleanups - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Warnings triggered by recent includefile cleanups
Date
Msg-id Pine.LNX.4.21.0007190132550.1545-100000@localhost.localdomain
Whole thread Raw
In response to Re: Warnings triggered by recent includefile cleanups  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane writes:

> @@ -55,6 +55,13 @@
>  #include "postgres.h"
>  #ifdef HAVE_LIMITS_H
>  #include <limits.h>
> +#ifndef MAXINT
> +#define MAXINT           INT_MAX
> +#endif
> +#else
> +#ifdef HAVE_VALUES_H
> +#include <values.h>
> +#endif
>  #endif
>  #include "fmgr.h"
>  #include "utils/builtins.h"
> 
> was dead code when it was installed.  The CVS log says
>     values.h patch from  Alex Howansky

He claimed that the compilation failed for him in the files   src/backend/optimizer/path/costsize.c
src/backend/utils/adt/date.c  src/backend/utils/adt/float.c
 
because MAXINT was undefined (although neither date.c nor float.c used
MAXINT at all in 6.5).

This problem is gone and one should use INT_MAX anyway.


-- 
Peter Eisentraut                  Sernanders väg 10:115
peter_e@gmx.net                   75262 Uppsala
http://yi.org/peter-e/            Sweden



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: btree split logic is fragile in the presence of large index items
Next
From: Tom Lane
Date:
Subject: Re: btree split logic is fragile in the presence of large index items