Re: BeOS take 2 - Mailing list pgsql-patches

From Peter Eisentraut
Subject Re: BeOS take 2
Date
Msg-id Pine.LNX.4.21.0006111152110.353-100000@localhost.localdomain
Whole thread Raw
In response to BeOS take 2  ("David Reid" <david@jetnet.co.uk>)
List pgsql-patches
David Reid writes:

> I've not modified anything (though I would normally remove the lines
> about .o files only being in the pgsql_beos tree)

It seems like you want to run make distclean before making patches.

> Looking at the code in pqcomm.c|h should a new define of
> NO_UNIX_SOCKETS be defined to clean up the defines around the unix
> socket code?

Yup.

> BTW, the IPC code for BeOS currently has  aLOT of defines of __BEOS__
> in it.  Any suggestions?

I didn't see any ifdef __BEOS__ in the IPC code in your patch. (Heck,
you're lucky you have IPC. The QNX port that was new for 7.0 had to
provide its own implementation of semaphores.)

What worries me is that BEOS seems to predefine bool with typedef.
PostgreSQL requires that bool is a `char', so if your system headers think
otherwise (`int' presumably), then we're in for a lot of trouble. How does
it look?


--
Peter Eisentraut                  Sernanders väg 10:115
peter_e@gmx.net                   75262 Uppsala
http://yi.org/peter-e/            Sweden


pgsql-patches by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: odbc patches
Next
From: Bruce Momjian
Date:
Subject: Re: NO-CREATE-TABLE and NO-LOCK-TABLE