On Sat, 24 Nov 2007, Tom Lane wrote:
> [PATCHES] [Fwd: Re: [HACKERS] Postgres 8.3 archive_command], Simon Riggs
> Applied.
Getting positive feedback that your archive command has triggered is
helpful for new users of this feature, and making it so that doesn't
happen anymore is a step backwards for them as far as I'm concerned.
Simon suggested he had a documentation update that was going to cover
this. I'd like to see that and a mention of this change in the release
notes before this is closed.
I already thought that the way the archive_command examples do everything
as a command line instead of calling a script sets a bad example practice,
and unless you call something you don't have options like "tweak your
archive_command script to do some logging of its own". This change makes
a much stronger case for saying outright the archive_command should call a
separate script, so you can adjust things including logging there. That
concept isn't even introduced by the current documentation. I know I was
surprised the first time I echo'd something from the script and discovered
it showed up in the server logs.
Sorry I didn't speak up before, I didn't think this was even a serious
candidate for applying to 8.3. Seemed like too much of a functional
change for slipping in this late and I presumed it was just going into the
8.4 queue.
--
* Greg Smith gsmith@gregsmith.com http://www.gregsmith.com Baltimore, MD
