RE: Rename injection point names in test_aio - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: Rename injection point names in test_aio
Date
Msg-id OSCPR01MB14966E0F977DFEAC871278056F5B32@OSCPR01MB14966.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: Rename injection point names in test_aio  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Dear Michael,

> > I have no objections for the patch, but I feel there are no concrete naming rules
> > (I confused while creating patches).
>
> There has been a sort of implied rule in the code to use lower
> characters, with terms separated by dashes.  Perhaps we could make
> that more official with an extra sentence in the docs about that.

Agreed.

> > Can we clarify that? E.g., first term should be a module or process,
> > or something like that.
>
> Not sure that it would be a good thing to put context-specific
> restrictions here.

My main concern is that in someday the name of injection points might be conflict,
and it might be painful to consider after the number of points is increased.
But it's OK to leave here now.

> Anyway, would you like to propose a patch for the documentation?

Sure, I did. Please see [1].

[1]:
https://www.postgresql.org/message-id/OSCPR01MB14966E14C1378DEE51FB7B7C5F5B32%40OSCPR01MB14966.jpnprd01.prod.outlook.com

Best regards,
Hayato Kuroda
FUJITSU LIMITED




pgsql-hackers by date:

Previous
From: jian he
Date:
Subject: Re: support create index on virtual generated column.
Next
From: Aleksander Alekseev
Date:
Subject: Re: doc patch: clarify the naming rule for injection_points