Request a Demo
Home   >   mailing lists

RE: Newly created replication slot may be invalidated by checkpoint - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: Newly created replication slot may be invalidated by checkpoint
Date
Msg-id OSCPR01MB149669E9A926943FF21798C91F51CA@OSCPR01MB14966.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: Newly created replication slot may be invalidated by checkpoint  (Amit Kapila <amit.kapila16@gmail.com>)
Responses RE: Newly created replication slot may be invalidated by checkpoint
List pgsql-hackers
Tree view 
Dear Amit, Vitaly,

> I was thinking some more about this solution. Won't it lead to the
> same problem if ReplicationSlotReserveWal() calls
> ReplicationSlotsComputeRequiredLSN() after the above calculation of
> checkpointer?

Exactly. I verified that in your patch, the invalidation can still happen if we
cannot finish the LSN computation before the KeepLogSegments().

Attached file can be applied atop 0001-Fix-invalidation-... and
v2-17-0001-Newly-created-replication... patches. It could invalidate the given
slot.

Best regards,
Hayato Kuroda
FUJITSU LIMITED
Attachment

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: "openssl" should not be optional
Next
From: Dilip Kumar
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication