RE: Add support for specifying tables in pg_createsubscriber. - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: Add support for specifying tables in pg_createsubscriber.
Date
Msg-id OSCPR01MB149664DEE1C8D02988E4666E9F55AA@OSCPR01MB14966.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Add support for specifying tables in pg_createsubscriber.  (Shubham Khanna <khannashubham1197@gmail.com>)
Responses RE: Add support for specifying tables in pg_createsubscriber.
List pgsql-hackers
Dear Shubham,

> The attached patch introduces a new '--table' option that can be
> specified after each '--database' argument.

Do we have another example which we consider the ordering of options? I'm unsure
for it. Does getopt_long() always return parsed options with the specified order?

> The syntax is like that used in 'vacuumdb'
> and supports multiple '--table' arguments per database, including
> optional column lists and row filters.

Vacuumdb nor pg_restore do not accept multiple --database, right?
I'm afraid that current API has too complex.

Per document:
```
+     <term><option>-f <replaceable class="parameter">table</replaceable></option></term>
+     <term><option>--table=<replaceable class="parameter">table</replaceable></option></term>
```

I feel using "-f" is not suitable. Let's remove the shorten option now.

Best regards,
Hayato Kuroda
FUJITSU LIMITED


pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [Proposal] Expose internal MultiXact member count function for efficient monitoring
Next
From: Ashutosh Bapat
Date:
Subject: Re: Document transition table triggers are not allowed on views/foreign tables