RE: StringInfo fixes, v19 edition. Plus a few oddities - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: StringInfo fixes, v19 edition. Plus a few oddities
Date
Msg-id OS9PR01MB12149FB6655C05E8CCF833957F5362@OS9PR01MB12149.jpnprd01.prod.outlook.com
Whole thread
In response to Re: StringInfo fixes, v19 edition. Plus a few oddities  (vignesh C <vignesh21@gmail.com>)
Responses Re: StringInfo fixes, v19 edition. Plus a few oddities
List pgsql-hackers
Dear hackers,

Thanks for updating the patch. I have a concern for the handling of colon (:).

In your patch a colon is used as the separator between data and sentence, and
it's not included in the translatable message. The blank exists only after the
colon.

It seems to break syntax rules in other languages. E.g., the blank seems to be
needed on both before and after the character in French [1]. In other language
the colon may not be used in the first place.

Based on that, How about including a colon in the translatable message?
We may need additional if-else statement but it's a collateral damage.

[1]
```
#: ../../../src/common/logging.c:276
#, c-format
msgid "error: "
msgstr "erreur : "
```

Best regards,
Hayato Kuroda
FUJITSU LIMITED


pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks
Next
From: Michael Paquier
Date:
Subject: Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks