Re: StringInfo fixes, v19 edition. Plus a few oddities - Mailing list pgsql-hackers

From vignesh C
Subject Re: StringInfo fixes, v19 edition. Plus a few oddities
Date
Msg-id CALDaNm0J0hmwCG_5NB3EMjuoYs91FaBy=9tH0BGn9ZJKdqfM2A@mail.gmail.com
Whole thread
In response to RE: StringInfo fixes, v19 edition. Plus a few oddities  ("Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>)
Responses Re: StringInfo fixes, v19 edition. Plus a few oddities
RE: StringInfo fixes, v19 edition. Plus a few oddities
List pgsql-hackers
On Mon, 27 Apr 2026 at 11:20, Hayato Kuroda (Fujitsu)
<kuroda.hayato@fujitsu.com> wrote:
>
> Dear hackers,
>
> Thanks for updating the patch. I have a concern for the handling of colon (:).
>
> In your patch a colon is used as the separator between data and sentence, and
> it's not included in the translatable message. The blank exists only after the
> colon.
>
> It seems to break syntax rules in other languages. E.g., the blank seems to be
> needed on both before and after the character in French [1]. In other language
> the colon may not be used in the first place.
>
> Based on that, How about including a colon in the translatable message?
> We may need additional if-else statement but it's a collateral damage.

Yeah, the better way is to go with if-else, the attached v4 version
patch has the changes for the same.

Regards,
Vignesh

Attachment

pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: Support logical replication of DDLs, take2
Next
From: Pavel Stehule
Date:
Subject: proposal: refactoring vacuum verbose output