RE: Skipping schema changes in publication - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: Skipping schema changes in publication
Date
Msg-id OS9PR01MB12149CC87E864D982B5619365F553A@OS9PR01MB12149.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: Skipping schema changes in publication  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: Skipping schema changes in publication
List pgsql-hackers
Dear Peter,

> ======
> src/bin/psql/tab-complete.in.c
>
> 4.
> - COMPLETE_WITH("EXCEPT TABLE (");
> + COMPLETE_WITH("EXCEPT ( TABLE");
>
> (this is in several places in  ALTER and CREATE)
>
> In v3 the space in "( TABLE" was changed to "(TABLE", but now in v4
> the space is back again. AFAICT the v3 change was in response to
> review [1] (comment #2). Was it reverted deliberately?

I think it's proper to have the blank before/after the parentheses. See the
existing example.

```
    /* ALTER TABLE <name> SPLIT PARTITION <name> */
    else if (Matches("ALTER", "TABLE", MatchAny, "SPLIT", "PARTITION", MatchAny))
        COMPLETE_WITH("INTO ( PARTITION");
```

Also, if we type till `CREATE PUBLICATION pub WITH` and type tab several times,
the suggested string is something like below:

```
CREATE PUBLICATION pub WITH ( PUBLISH
```

It means normally the blank exists in between the term.

Best regards,
Hayato Kuroda
FUJITSU LIMITED




pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Fix HAVING-to-WHERE pushdown with nondeterministic collations
Next
From: Amit Kapila
Date:
Subject: Re: Skipping schema changes in publication