On Tue, Mar 31, 2026 at 2:54 PM Hayato Kuroda (Fujitsu)
<kuroda.hayato@fujitsu.com> wrote:
>
> Dear Peter,
>
> > ======
> > src/bin/psql/tab-complete.in.c
> >
> > 4.
> > - COMPLETE_WITH("EXCEPT TABLE (");
> > + COMPLETE_WITH("EXCEPT ( TABLE");
> >
> > (this is in several places in ALTER and CREATE)
> >
> > In v3 the space in "( TABLE" was changed to "(TABLE", but now in v4
> > the space is back again. AFAICT the v3 change was in response to
> > review [1] (comment #2). Was it reverted deliberately?
>
> I think it's proper to have the blank before/after the parentheses. See the
> existing example.
>
> ```
> /* ALTER TABLE <name> SPLIT PARTITION <name> */
> else if (Matches("ALTER", "TABLE", MatchAny, "SPLIT", "PARTITION", MatchAny))
> COMPLETE_WITH("INTO ( PARTITION");
> ```
>
> Also, if we type till `CREATE PUBLICATION pub WITH` and type tab several times,
> the suggested string is something like below:
>
> ```
> CREATE PUBLICATION pub WITH ( PUBLISH
> ```
>
> It means normally the blank exists in between the term.
>
OK. I didn't really have an opinion about it. I was only pointing out
it was changed in v3 and then changed again in v4 so I was just
checking if it was deliberate.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
