Request a Demo
Home   >   mailing lists

RE: BUG #19547: libpqrcv_create_slot dereferences NULL on a malformed CREATE_REPLICATION_SLOT reply - Mailing list pgsql-bugs

From Hayato Kuroda (Fujitsu)
Subject RE: BUG #19547: libpqrcv_create_slot dereferences NULL on a malformed CREATE_REPLICATION_SLOT reply
Date
Msg-id OS9PR01MB1214957C5C51D521A4D7FFA9BF5C72@OS9PR01MB12149.jpnprd01.prod.outlook.com
Whole thread
In response to Re: BUG #19547: libpqrcv_create_slot dereferences NULL on a malformed CREATE_REPLICATION_SLOT reply  (Kenny Chen <kennychen851228@gmail.com>)
Responses Re: BUG #19547: libpqrcv_create_slot dereferences NULL on a malformed CREATE_REPLICATION_SLOT reply
List pgsql-bugs
Tree view 
Dear Kenny,

> Right, CREATE_REPLICATION_SLOT always returns exactly 4 columns, so != 4 is
> more accurate.  v3 attached uses != 4 and drops "or more" from the errdetail.

Basically LGTM. From my perspective the code comment might be too detail:
"CREATE_REPLICATION_SLOT has always returned a single row with four columns"
might be enough. But it's not the strong opinion - let's confirm the Fujii-san's idea.

Best regards,
Hayato Kuroda
FUJITSU LIMITED

pgsql-bugs by date:

Previous
From: Richard Guo
Date:
Subject: Re: Bug in heap_get_root_tuples
Next
From: Fujii Masao
Date:
Subject: Re: BUG #19547: libpqrcv_create_slot dereferences NULL on a malformed CREATE_REPLICATION_SLOT reply