Request a Demo
Home   >   mailing lists

Re: BUG #19547: libpqrcv_create_slot dereferences NULL on a malformed CREATE_REPLICATION_SLOT reply - Mailing list pgsql-bugs

From Fujii Masao
Subject Re: BUG #19547: libpqrcv_create_slot dereferences NULL on a malformed CREATE_REPLICATION_SLOT reply
Date
Msg-id CAHGQGwHDwn+2fH9q99NxJyOqKRET0sCP=_pb01+Ahx+XmXi_QA@mail.gmail.com
Whole thread
In response to RE: BUG #19547: libpqrcv_create_slot dereferences NULL on a malformed CREATE_REPLICATION_SLOT reply  ("Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>)
Responses RE: BUG #19547: libpqrcv_create_slot dereferences NULL on a malformed CREATE_REPLICATION_SLOT reply
List pgsql-bugs
Tree view 
On Thu, Jul 16, 2026 at 9:36 AM Hayato Kuroda (Fujitsu)
<kuroda.hayato@fujitsu.com> wrote:
>
> Dear Kenny,
>
> > Right, CREATE_REPLICATION_SLOT always returns exactly 4 columns, so != 4 is
> > more accurate.  v3 attached uses != 4 and drops "or more" from the errdetail.
>
> Basically LGTM. From my perspective the code comment might be too detail:
> "CREATE_REPLICATION_SLOT has always returned a single row with four columns"
> might be enough.

+1

So I've updated the comment to a simpler version and pushed the patch. Thanks!

Regards,

--
Fujii Masao

pgsql-bugs by date:

Previous
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: BUG #19547: libpqrcv_create_slot dereferences NULL on a malformed CREATE_REPLICATION_SLOT reply
Next
From: Maaz Syed Adeeb
Date:
Subject: Re: CREATE INDEX with an expression in an INCLUDE column fails with XX000 "unrecognized node type" instead of 0A000 on master