RE: [PATCH] pg_walsummary: suppress limit output with --quiet - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: [PATCH] pg_walsummary: suppress limit output with --quiet
Date
Msg-id OS7PR01MB18317F7CE7D65C26AF925CF27F5942@OS7PR01MB18317.jpnprd01.prod.outlook.com
Whole thread
In response to Re: [PATCH] pg_walsummary: suppress limit output with --quiet  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: [PATCH] pg_walsummary: suppress limit output with --quiet
List pgsql-hackers
Dear Fujii-san,

> Thanks for updating the patch! LGTM.
> 
> I've attached an updated version with some cosmetic changes and revised
> commit log messages. I also created a patch for REL_17_STABLE.

Thanks for updating the patch. One minor point: command_like() might be
better in below if we assume the command returns 0 and no stderr. But
not a strong opinion.

```
+command_checks_all([ 'pg_walsummary', '-q', @summaries ],
+    0, [qr/\A\z/], [qr/\A\z/], "-q suppresses all output");
```

Best regards,
Hayato Kuroda
FUJITSU LIMITED


pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Fix reindexdb with parallel index-level conrurrent run
Next
From: shihao zhong
Date:
Subject: Re: REPACK (CONCURRENTLY) might keep dropped-column data