Re: [PATCH] pg_walsummary: suppress limit output with --quiet - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: [PATCH] pg_walsummary: suppress limit output with --quiet
Date
Msg-id CAHGQGwF0vTo6xCWU-ZzAphS8beqdRRa3AZunXhEFUmDnSQ6b5A@mail.gmail.com
Whole thread
In response to RE: [PATCH] pg_walsummary: suppress limit output with --quiet  ("Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>)
Responses RE: [PATCH] pg_walsummary: suppress limit output with --quiet
List pgsql-hackers
On Wed, Oct 7, 2026 at 10:56 AM Hayato Kuroda (Fujitsu)
<kuroda.hayato@fujitsu.com> wrote:
> Thanks for updating the patch. One minor point: command_like() might be
> better in below if we assume the command returns 0 and no stderr. But
> not a strong opinion.
>
> ```
> +command_checks_all([ 'pg_walsummary', '-q', @summaries ],
> +       0, [qr/\A\z/], [qr/\A\z/], "-q suppresses all output");
> ```

Okay, I've replaced it with command_like(). How about the attached updated
patches?

Regards,

--
Fujii Masao

Attachment

pgsql-hackers by date:

Previous
From: shihao zhong
Date:
Subject: Re: REPACK (CONCURRENTLY) might keep dropped-column data
Next
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: [PATCH] pg_walsummary: suppress limit output with --quiet