RE: Remove "FROM" in "DELETE FROM" when using tab-completion - Mailing list pgsql-hackers

From tanghy.fnst@fujitsu.com
Subject RE: Remove "FROM" in "DELETE FROM" when using tab-completion
Date
Msg-id OS0PR01MB6113B2E34CD215404BC00E1DFB539@OS0PR01MB6113.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: Remove "FROM" in "DELETE FROM" when using tab-completion  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Remove "FROM" in "DELETE FROM" when using tab-completion
List pgsql-hackers
On Tuesday, May 11, 2021 2:53 PM, Michael Paquier <michael@paquier.xyz> wrote
>    else if (TailMatches("DELETE", "FROM", MatchAny))
>            COMPLETE_WITH("USING", "WHERE");
>-   /* XXX: implement tab completion for DELETE ... USING */
>
>Why are you removing that?  This sentence is still true, no?

IIRC, XXX in comment is used to flag something that is bogus but works.
When the sentence introduced here in f5ab0a14, the fix for "DELETE ... USING" is not as good as it is now.(I guess
that'swhy the comment was added). And for now, IMHO, we can remove the comment directly.  

If my understanding here is wrong, please let me know and that would be great to learn more about PG.

Regards,
Tang



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Multiple hosts in connection string failed to failover in non-hot standby mode
Next
From: Julien Rouhaud
Date:
Subject: Re: compute_query_id and pg_stat_statements