Re: [HACKERS] [POC] Faster processing at Gather node - Mailing list pgsql-hackers

From Jim Van Fleet
Subject Re: [HACKERS] [POC] Faster processing at Gather node
Date
Msg-id OF4562CA08.43150594-ON862581CF.0064A5FA-862581CF.00766A15@notes.na.collabserv.com
Whole thread Raw
In response to [HACKERS] [POC] Faster processing at Gather node  (Rafia Sabih <rafia.sabih@enterprisedb.com>)
Responses Re: [HACKERS] [POC] Faster processing at Gather node  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Ran this change with hammerdb  on a power 8 firestone

with 2 socket, 20 core
9.6 base        --  451991 NOPM
0926_master -- 464385 NOPM
11_04master -- 449177 NOPM
11_04_patch -- 431423 NOPM
-- two socket patch is a little down from previous base runs

With one socket
9.6 base          -- 393727 NOPM
v10rc1_base -- 350958 NOPM
11_04master -- 306506 NOPM
11_04_patch -- 313179 NOPM
--  one socket 11_04 master is quite a bit down from 9.6 and v10rc1_base -- the patch is up a bit over the base

Net -- the patch is about the same as current base on two socket, and on one socket  -- consistent with your pgbench (?) findings

As an aside, it is perhaps a worry that one socket is down over 20% from 9.6 and over 10% from v10rc1

Jim

pgsql-hackers-owner@postgresql.org wrote on 11/04/2017 06:08:31 AM:

> On hydra (PPC), these changes didn't help much.  Timings:
>
> master: 29605.582, 29753.417, 30160.485
> patch: 28218.396, 27986.951, 26465.584
>
> That's about a 5-6% improvement.  On my MacBook, though, the
> improvement was quite a bit more:
>
> master: 21436.745, 20978.355, 19918.617
> patch: 15896.573, 15880.652, 15967.176
>
> Median-to-median, that's about a 24% improvement.
>
> Any reviews appreciated.
>
> Thanks,
>
> --
> Robert Haas
> EnterpriseDB:
https://urldefense.proofpoint.com/v2/url?
> u=http-3A__www.enterprisedb.com&d=DwIBaQ&c=jf_iaSHvJObTbx-
> siA1ZOg&r=Glx_6-ZyGFPdLCdb8Jr7QJHrJIbUJO1z6oi-JHO8Htk&m=-
> I8r3tfguIVgEpNumrjWTKOGkJWIbHQNT2M2-02-8cU&s=39p2vefOiiZS9ZooPYkZ97U66hw5osqmkCGcikgZCik&e=
> The Enterprise PostgreSQL Company
> [attachment "shm-mq-less-spinlocks-v1.2.patch" deleted by Jim Van
> Fleet/Austin/Contr/IBM]
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
> To make changes to your subscription:
>
https://urldefense.proofpoint.com/v2/url?
> u=http-3A__www.postgresql.org_mailpref_pgsql-2Dhackers&d=DwIDAg&c=jf_iaSHvJObTbx-
> siA1ZOg&r=Glx_6-ZyGFPdLCdb8Jr7QJHrJIbUJO1z6oi-JHO8Htk&m=-
> I8r3tfguIVgEpNumrjWTKOGkJWIbHQNT2M2-02-8cU&s=aL2TI3avKN4drlXk915UM2RFixyvUsZ2axDjB2FG9G0&e=

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: [HACKERS] Display number of heap accesses for index scans
Next
From: Andres Freund
Date:
Subject: Re: [HACKERS] [POC] Faster processing at Gather node