Re: Tab complete for CREATE SUBSCRIPTION ... CONECTION does not work - Mailing list pgsql-hackers

From Japin Li
Subject Re: Tab complete for CREATE SUBSCRIPTION ... CONECTION does not work
Date
Msg-id ME3P282MB3166AD0CB975CF97E09C19DBB69FA@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM
Whole thread Raw
In response to Re: Tab complete for CREATE SUBSCRIPTION ... CONECTION does not work  (Shubham Khanna <khannashubham1197@gmail.com>)
List pgsql-hackers
On Tue, 26 Dec 2023 at 18:10, Shubham Khanna <khannashubham1197@gmail.com> wrote:
> On Tue, Dec 26, 2023 at 3:02 PM Japin Li <japinli@hotmail.com> wrote:
>>
>>
>> Hi hacker,
>>
>> As $subject detailed, the tab-complete cannot work such as:
>>
>>    CREATE SUBSCRIPTION sub CONNECTION 'dbname=postgres port=6543' \t
>>
>> It seems that the get_previous_words() could not parse the single quote.
>>
>> OTOH, it works for CREATE SUBSCRIPTION sub CONNECTION xx \t, should we fix it?
>>
> I reviewed the Patch and it looks fine to me.
>
Thanks for the review.

--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Synchronizing slots from primary to standby
Next
From: John Naylor
Date:
Subject: Re: A typo in a messsage?