Re: Tab complete for CREATE SUBSCRIPTION ... CONECTION does not work - Mailing list pgsql-hackers

From Shubham Khanna
Subject Re: Tab complete for CREATE SUBSCRIPTION ... CONECTION does not work
Date
Msg-id CAHv8RjLJ36mPv-hadPqF_Xj51AY5csy6MSBLebrS921OnQgeHA@mail.gmail.com
Whole thread Raw
In response to Tab complete for CREATE SUBSCRIPTION ... CONECTION does not work  (Japin Li <japinli@hotmail.com>)
Responses Re: Tab complete for CREATE SUBSCRIPTION ... CONECTION does not work  (Japin Li <japinli@hotmail.com>)
List pgsql-hackers
On Tue, Dec 26, 2023 at 3:02 PM Japin Li <japinli@hotmail.com> wrote:
>
>
> Hi hacker,
>
> As $subject detailed, the tab-complete cannot work such as:
>
>    CREATE SUBSCRIPTION sub CONNECTION 'dbname=postgres port=6543' \t
>
> It seems that the get_previous_words() could not parse the single quote.
>
> OTOH, it works for CREATE SUBSCRIPTION sub CONNECTION xx \t, should we fix it?
>
I reviewed the Patch and it looks fine to me.

Thanks and Regards,
Shubham Khanna.



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Synchronizing slots from primary to standby
Next
From: Michael Paquier
Date:
Subject: Re: Show WAL write and fsync stats in pg_stat_io