Re: CLUSTER patch and regression test - Mailing list pgsql-patches

From Christopher Kings-Lynne
Subject Re: CLUSTER patch and regression test
Date
Msg-id GNELIHDDFBOCMGBFGEFOCEJFCDAA.chriskl@familyhealth.com.au
Whole thread Raw
In response to Re: CLUSTER patch and regression test  (Neil Conway <nconway@klamath.dyndns.org>)
List pgsql-patches
Yeah - Alvaro needs to sync with Tom's catalog index improvements - he
should be able to see example code in tablecmds.c, or in the orginal version
of the file this error is in?

Chris

> Alvaro Herrera <alvherre@atentus.com> writes:
> > I sent the CLUSTER patch a few days ago and I think it was missed.  I
> > append it again, this time including the regression test files.
>
> Applying the patch to current CVS and compiling produces:
>
> gcc -g3 -O0 -DPS_USE_NONE -Wall -Wmissing-prototypes
> -Wmissing-declarations -I../../../src/include   -c -o cluster.o
> cluster.c -MMD
> cluster.c: In function `swap_relfilenodes':
> cluster.c:383: `Num_pg_class_indices' undeclared (first use in
> this function)
> cluster.c:383: (Each undeclared identifier is reported only once
> cluster.c:383: for each function it appears in.)
> cluster.c:432: warning: implicit declaration of function
> `CatalogOpenIndices'
> cluster.c:432: `Name_pg_class_indices' undeclared (first use in
> this function)
> cluster.c:433: too many arguments to function `CatalogIndexInsert'
> cluster.c:434: too many arguments to function `CatalogIndexInsert'
> cluster.c:435: warning: implicit declaration of function
> `CatalogCloseIndices'
> cluster.c:383: warning: unused variable `irels'
> make[3]: *** [cluster.o] Error 1
> make[3]: Leaving directory `/home/nconway/pgsql/src/backend/commands'
>
> Cheers,
>
> Neil
>
> --
> Neil Conway <neilconway@rogers.com>
> PGP Key ID: DB3C29FC
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
>     (send "unregister YourEmailAddressHere" to majordomo@postgresql.org)
>


pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: improve SET CONSTRAINTS
Next
From: Neil Conway
Date:
Subject: Re: improve SET CONSTRAINTS