Re: improve SET CONSTRAINTS - Mailing list pgsql-patches

From Neil Conway
Subject Re: improve SET CONSTRAINTS
Date
Msg-id 87fzxqf4zv.fsf@klamath.dyndns.org
Whole thread Raw
In response to Re: improve SET CONSTRAINTS  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: improve SET CONSTRAINTS  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane <tgl@sss.pgh.pa.us> writes:
> Neil Conway <nconway@klamath.dyndns.org> writes:
> > I also took the opportunity to remove a bunch of code in trigger.c
> > that wasn't doing anything useful, AFAICS -- according to SQL99, SET
> > CONSTRAINTS should only apply to the current transaction.
>
> I would assume that Jan and Stephan put that code in for a reason.

In that case, some documentation of its intended purpose would be
nice. It doesn't help that the code I cut out was a particularly ugly
cut-n-paste job.

As an aside, I'm not too fond of adding code with zero present
functionality with the vague idea that it may one day be useful.

> "Rip out anything I can't find in SQL99" is not the way we do things
> around here ...

I think that's unfair, and it's certainly not the methodology I'm
following.

Cheers,

Neil

--
Neil Conway <neilconway@rogers.com>
PGP Key ID: DB3C29FC

pgsql-patches by date:

Previous
From: "Christopher Kings-Lynne"
Date:
Subject: Re: CLUSTER patch and regression test
Next
From: Tom Lane
Date:
Subject: Re: improve SET CONSTRAINTS