Re: [HACKERS] Optional message to user when terminating/cancelling backend - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: [HACKERS] Optional message to user when terminating/cancelling backend
Date
Msg-id FFDDE5AE-B5A0-4992-915E-58A9FB662599@yesql.se
Whole thread Raw
In response to Re: [HACKERS] Optional message to user when terminating/cancellingbackend  (Michael Paquier <michael@paquier.xyz>)
Responses Re: [HACKERS] Optional message to user when terminating/cancellingbackend  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
> On 06 Apr 2018, at 04:49, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Thu, Apr 05, 2018 at 11:33:57PM +0200, Daniel Gustafsson wrote:
>> It seemed like a good idea at the time to indicate which part was submitted by
>> the user, but looking at it now the colon sign is a pretty clear indicator
>> already.
>
> Dropping the quotes is more consistent with other error messages.  We
> don't bother about quoting things for example with system-related errors
> generated by strerror().

Yep, I completely agree.  Attached are patches with the quotes removed and
rebased since Oids were taken etc.

cheers ./daniel


Attachment

pgsql-hackers by date:

Previous
From: Ernst-Georg Schmid
Date:
Subject: AW: Get the name of the target Relation from Query struct?
Next
From: Magnus Hagander
Date:
Subject: Re: Online enabling of checksums