Re: basebackup: do not verify checksums on pages written before enabling checksums - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: basebackup: do not verify checksums on pages written before enabling checksums
Date
Msg-id FE7457FE-6108-422C-98AB-03E139B1BCFB@yesql.se
Whole thread
In response to Re: basebackup: do not verify checksums on pages written before enabling checksums  (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>)
Responses Re: fix pg_mkdir_p to tolerate concurrent directory creation
Re: fix pg_mkdir_p to tolerate concurrent directory creation
Re: basebackup: do not verify checksums on pages written before enabling checksums
List pgsql-hackers
> On 18 Aug 2026, at 14:39, Bertrand Drouvot <bertranddrouvot.pg@gmail.com> wrote:

> Shouldn't hit be incremented only when the injection point is attached?

Good point, will fix.

> +  checksum ^= checksum;
>
> That's same as "checksum =  0". That works because 0 is not a valid value but
> was the intend to "checksum ^= 1"? to express that we want a different checksum?

Ugh, sorry, I didn't notice that I hadn't replaced my debugcode before
generating the patch, I blame the lack of caffeine this morning.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Bertrand Drouvot
Date:
Subject: Re: basebackup: do not verify checksums on pages written before enabling checksums
Next
From: Pavel Stehule
Date:
Subject: Re: missing possibility to use alternative translated month names in to_char function