Re: Possible bug in vacuum redo - Mailing list pgsql-hackers

From Hiroshi Inoue
Subject Re: Possible bug in vacuum redo
Date
Msg-id EKEJJICOHDIEMGPNIFIJEEIKGEAA.Inoue@tpf.co.jp
Whole thread Raw
In response to Possible bug in vacuum redo  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Possible bug in vacuum redo  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> -----Original Message-----
> From: Tom Lane
> 
> In the vacuum tuple-chain moving logic, shouldn't the lines that update
> the new tuple's t_ctid (vacuum.c lines 1882-1891 in current sources)
> be moved up to before the log_heap_move call at line 1866?
> 
> It appears to me that as the code stands, log_heap_move will log the new
> tuple containing the wrong t_ctid; therefore, if we crash and have to
> redo the transaction from WAL, the wrong t_ctid will be restored.  No?

AFAIR t_ctid isn't logged in WAL.

regards,
Hiroshi Inoue


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: contrib idea
Next
From: Tom Lane
Date:
Subject: Re: Possible bug in vacuum redo