Possible bug in vacuum redo - Mailing list pgsql-hackers

From Tom Lane
Subject Possible bug in vacuum redo
Date
Msg-id 19627.1008721326@sss.pgh.pa.us
Whole thread Raw
Responses Re: Possible bug in vacuum redo  ("Hiroshi Inoue" <Inoue@tpf.co.jp>)
List pgsql-hackers
In the vacuum tuple-chain moving logic, shouldn't the lines that update
the new tuple's t_ctid (vacuum.c lines 1882-1891 in current sources)
be moved up to before the log_heap_move call at line 1866?

It appears to me that as the code stands, log_heap_move will log the new
tuple containing the wrong t_ctid; therefore, if we crash and have to
redo the transaction from WAL, the wrong t_ctid will be restored.  No?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Thomas Swan
Date:
Subject: Re: Thoughts on the location of configuration files
Next
From: "Andrew G. Hammond"
Date:
Subject: Re: Explicit config patch 7.2B4